[1839] Fix ConflictingPublicNetworkAccessAndVirtualNetworkConfiguration #112
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to issue hashicorp/terraform-provider-azurerm#26098 We must ignore changes to the argument as it becomes enforced from azurerm version v3.105.0. This will allow us to upgrade azurerm in all the repositories. Then we will be able to set public_network_access_enabled to false and remove this ignore_changes.
saliceti
force-pushed
the
1839-bug-conflictingpublicnetworkaccessandvirtualnetworkconfiguration
branch
from
bd32b98 to
779ab63
Compare
RMcVelia
approved these changes
Aug 13, 2024
saliceti
deleted the
1839-bug-conflictingpublicnetworkaccessandvirtualnetworkconfiguration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related to issue hashicorp/terraform-provider-azurerm#26098
We must ignore changes to the public_network_access_enabled argument as it becomes enforced from azurerm version v3.105.0.
This will allow us to upgrade azurerm in all the repositories. Then we will be able to set public_network_access_enabled to false and remove this ignore_changes.
Changes proposed in this pull request
Add public_network_access_enabled to ignore_changes lifecycle
Guidance to review
See testing in https://hedgedoc.teacherservices.cloud/GfdrzaeGRKGO49k69ANvrQ?edit
Checklist
Devopslabel